[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 12/28] qapi: Clean up after commit 3d344c2
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v4 12/28] qapi: Clean up after commit 3d344c2 |
Date: |
Fri, 3 Mar 2017 13:32:32 +0100 |
Drop unused QIV_STACK_SIZE and unused qobject_input_start_struct()
parameter errp.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qapi/qobject-input-visitor.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c
index f3b6713..2c2f883 100644
--- a/qapi/qobject-input-visitor.c
+++ b/qapi/qobject-input-visitor.c
@@ -21,8 +21,6 @@
#include "qapi/qmp/types.h"
#include "qapi/qmp/qerror.h"
-#define QIV_STACK_SIZE 1024
-
typedef struct StackObject
{
QObject *obj; /* Object being visited */
@@ -103,8 +101,7 @@ static void qdict_add_key(const char *key, QObject *obj,
void *opaque)
}
static const QListEntry *qobject_input_push(QObjectInputVisitor *qiv,
- QObject *obj, void *qapi,
- Error **errp)
+ QObject *obj, void *qapi)
{
GHashTable *h;
StackObject *tos = g_new0(StackObject, 1);
@@ -170,7 +167,6 @@ static void qobject_input_start_struct(Visitor *v, const
char *name, void **obj,
{
QObjectInputVisitor *qiv = to_qiv(v);
QObject *qobj = qobject_input_get_object(qiv, name, true, errp);
- Error *err = NULL;
if (obj) {
*obj = NULL;
@@ -184,11 +180,7 @@ static void qobject_input_start_struct(Visitor *v, const
char *name, void **obj,
return;
}
- qobject_input_push(qiv, qobj, obj, &err);
- if (err) {
- error_propagate(errp, err);
- return;
- }
+ qobject_input_push(qiv, qobj, obj);
if (obj) {
*obj = g_malloc0(size);
@@ -216,7 +208,7 @@ static void qobject_input_start_list(Visitor *v, const char
*name,
return;
}
- entry = qobject_input_push(qiv, qobj, list, errp);
+ entry = qobject_input_push(qiv, qobj, list);
if (list) {
if (entry) {
*list = g_malloc0(size);
--
2.7.4
- [Qemu-devel] [PATCH v4 03/28] qmp-test: New, covering basic QMP protocol, (continued)
- [Qemu-devel] [PATCH v4 03/28] qmp-test: New, covering basic QMP protocol, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 08/28] qmp: Drop duplicated QMP command object checks, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 09/28] qmp: Eliminate silly QERR_QMP_* macros, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 18/28] test-qobject-input-visitor: Use strict visitor, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 01/28] qga: Fix crash on non-dictionary QMP argument, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 11/28] qapi: Improve a QObject input visitor error message, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 06/28] qapi-introspect: Mangle --prefix argument properly for C, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 04/28] qmp: Dumb down how we run QMP command registration, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 12/28] qapi: Clean up after commit 3d344c2,
Markus Armbruster <=
- [Qemu-devel] [PATCH v4 15/28] qapi: Drop string input visitor method optional(), Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 27/28] qapi: Fix object input visit beyond end of list, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 17/28] qom: Make object_property_set_qobject()'s input visitor strict, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 26/28] tests: Cover input visit beyond end of list, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 23/28] tests: Cover partial input visit of list, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 25/28] qapi: Make input visitors detect unvisited list tails, Markus Armbruster, 2017/03/03