Re: [Qemu-devel] [PATCH 0/2] sm501: drop obsolete code

[BALATON Zoltan]

Hello,

On Mon, 6 Mar 2017, Gerd Hoffmann wrote:
> This little series drops a bunch of code which is not needed any more.
> Nowdays qemu console only uses 32bpp surfaces.
>
> BALATON, this should simplify your job of getting the pixel conversions
> right.  Feel free to add this to your series.

Thanks but this would actually complicate my job, as applying this before 
my series would need rebasing my patches again to this change and after 
that it won't apply as it is because the draw functions are changed. Maybe 
this change could be done independently after my series gets in. Having 
the unused functions should not cause any problems other than some unused 
code in the executable so it does not seem to matter for pixel 
conversions.

Regards,
BALATON Zoltan

> Gerd Hoffmann (2):
>  sm501: drop support for anything but 32bpp
>  sm501: drop sm501_template.h
>
> hw/display/sm501.c          | 167 +++++++++++++++++++++++---------------------
> hw/display/sm501_template.h | 145 --------------------------------------
> 2 files changed, 86 insertions(+), 226 deletions(-)
> delete mode 100644 hw/display/sm501_template.h