Re: [Qemu-devel] [PATCH v4 16/28] qapi: Make string input and opts visitor require non-null input

[Markus Armbruster]

Philippe Mathieu-Daudé <address@hidden> writes:

> On 03/03/2017 09:32 AM, Markus Armbruster wrote:
>> The string input visitor tries to cope with null input.  Null input
>> isn't used anywhere, and isn't covered by tests.  Unsurprisingly, it
>> doesn't fully work: start_list() crashes because it passes the input
>> via parse_str() to strtoll() unchecked.
>>
>> Make string_input_visitor_new() assert its argument isn't null, and
>> drop the code trying to deal with null input.
>>
>> The opts visitor crashes when you try to actually visit something with
>> null input.  Make opts_visitor_new() assert its argument isn't null,
>> mostly for clarity.
>>
>> qobject_input_visitor_new() already asserts its argument isn't null.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Since the series has been merged already, there's no way for me to
record your review with the commit.  Thanks anyway!