Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

[Philippe Mathieu-Daudé]

On 03/08/2017 03:25 PM, Eric Blake wrote:
> On 03/08/2017 12:18 PM, Max Reitz wrote:
> > In order to use error_setg() and similar functions, we need to include
> > qapi/error.h.
> >
> > Signed-off-by: Max Reitz <address@hidden>
> > ---
> >  block/archipelago.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Reviewed-by: Eric Blake <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> Does this mean our automated buildbots aren't building archipelago by
> default?
>
> > diff --git a/block/archipelago.c b/block/archipelago.c
> > index 2449cfc702..01c4ff2f7d 100644
> > --- a/block/archipelago.c
> > +++ b/block/archipelago.c
> > @@ -55,6 +55,7 @@
> >  #include "block/block_int.h"
> >  #include "qemu/error-report.h"
> >  #include "qemu/thread.h"
> > +#include "qapi/error.h"
> >  #include "qapi/qmp/qint.h"
> >  #include "qapi/qmp/qstring.h"
> >  #include "qapi/qmp/qjson.h"