[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9 09/47] qapi: Fix to reject empty union b
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.9 09/47] qapi: Fix to reject empty union base gracefully |
Date: |
Tue, 14 Mar 2017 10:58:29 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/13/2017 01:18 AM, Markus Armbruster wrote:
> Common Python pitfall: 'assert base_members' fires on [] in addition
> to None. Correct to 'assert base_members is not None'.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi.py | 2 +-
> tests/qapi-schema/union-base-empty.err | 11 +----------
> 2 files changed, 2 insertions(+), 11 deletions(-)
>
> +++ b/tests/qapi-schema/union-base-empty.err
> @@ -1,10 +1 @@
> -Traceback (most recent call last):
> - File "tests/qapi-schema/test-qapi.py", line 56, in <module>
> - schema = QAPISchema(sys.argv[1])
> - File "scripts/qapi.py", line 1483, in __init__
> - self.exprs = check_exprs(parser.exprs)
> - File "scripts/qapi.py", line 917, in check_exprs
> - check_union(expr, info)
> - File "scripts/qapi.py", line 734, in check_union
> - assert base_members
> -AssertionError
> +tests/qapi-schema/union-base-empty.json:5: Discriminator 'type' is not a
> member of base struct 'Empty'
Much nicer message.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH for-2.9 08/47] tests/qapi-schema: Cover empty union base, (continued)
- [Qemu-devel] [PATCH for-2.9 04/47] docs/qapi-code-gen.txt: Drop confusing reference to 'gen', Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 02/47] qapi: Make doc comments optional where we don't need them, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 09/47] qapi: Fix to reject empty union base gracefully, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 01/47] qapi: Factor QAPISchemaParser._include() out of .__init__(), Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 10/47] qapi2texi: Fix up output around #optional, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 13/47] qapi: Fix QAPISchemaEnumType.is_implicit() for 'QType', Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 06/47] qapi: Have each QAPI schema declare its name rule violations, Markus Armbruster, 2017/03/13