qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.9 32/47] qapi: Move detection of doc / exp


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH for-2.9 32/47] qapi: Move detection of doc / expression name mismatch
Date: Wed, 15 Mar 2017 08:39:40 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> Move the check whether the doc matches the expression name from
>> check_definition_doc() to check_exprs().  This changes the error
>> location from the comment to the expression.  Makes sense as the
>> message talks about the expresion: "Definition of '%s' follows
>
> s/expresion/expression/

Will fix.

>> documentation for '%s'".  It's also a step towards getting rid of
>> check_docs().
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  scripts/qapi.py                      | 28 ++++++++++++++++++----------
>>  tests/qapi-schema/doc-bad-symbol.err |  2 +-
>>  2 files changed, 19 insertions(+), 11 deletions(-)
>> 
>
> Reviewed-by: Eric Blake <address@hidden>

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]