[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-img: show help for invalid global options
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-img: show help for invalid global options |
Date: |
Thu, 16 Mar 2017 03:07:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 |
On 13.03.2017 06:11, Stefan Hajnoczi wrote:
> The qemu-img sub-command executes regardless of invalid global options:
>
> $ qemu-img --foo info test.img
> qemu-img: unrecognized option '--foo'
> image: test.img
> ...
>
> The unrecognized option warning may be missed by the user. This can
> hide incorrect command-lines in scripts and confuse users.
>
> This patch prints the help information and terminates instead of
> executing the sub-command.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> qemu-img.c | 1 +
> 1 file changed, 1 insertion(+)
Well, now you get blown away by a wall of text and spotting what went
wrong is actually not quite simple. Maybe we should follow the way of
the coreutils, that is:
qemu-img: unrecognized option '--foo'
Try 'qemu-img --help' for more information.
?
Max
signature.asc
Description: OpenPGP digital signature