[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 10/21] char: useless NULL check
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v3 10/21] char: useless NULL check |
Date: |
Thu, 16 Mar 2017 13:21:10 +0400 |
g_strdup(NULL) returns NULL already.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
chardev/char.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/chardev/char.c b/chardev/char.c
index aee8b4555d..33dbab6981 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -764,7 +764,7 @@ void qemu_chr_parse_common(QemuOpts *opts, ChardevCommon
*backend)
const char *logfile = qemu_opt_get(opts, "logfile");
backend->has_logfile = logfile != NULL;
- backend->logfile = logfile ? g_strdup(logfile) : NULL;
+ backend->logfile = g_strdup(logfile);
backend->has_logappend = true;
backend->logappend = qemu_opt_get_bool(opts, "logappend", false);
--
2.12.0.191.gc5d8de91d
- [Qemu-devel] [PATCH v3 00/21] chardev clean-ups & tests (after 2.9), Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 01/21] char: remove qemu_chr_be_generic_open, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 02/21] mux: simplfy muxes_realize_done, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 04/21] container: don't leak container reference, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 03/21] xen: use a better chardev type check, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 05/21] char: add a /chardevs container, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 06/21] vl: add todo note about root container cleanup, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 07/21] char: use /chardevs container instead of chardevs list, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 08/21] char: remove qemu_chardev_add, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 09/21] char: remove chardevs list, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 10/21] char: useless NULL check,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v3 12/21] char-socket: update local address after listen, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 11/21] char-socket: introduce update_disconnected_filename(), Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 13/21] char-socket: add 'addr' property, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 14/21] char-socket: add 'connected' property, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 15/21] char-udp: flush as much buffer as possible, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 16/21] tests: add alias check in /char/ringbuf, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 17/21] tests: add /char/pipe test, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 18/21] tests: add /char/file test, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 19/21] tests: add /char/socket test, Marc-André Lureau, 2017/03/16
- [Qemu-devel] [PATCH v3 20/21] tests: add /char/udp test, Marc-André Lureau, 2017/03/16