Re: [Qemu-devel] qemu-ga static compilation

[Peter Maydell]

On 20 March 2017 at 13:57, Stefan Hajnoczi <address@hidden> wrote:
> I guess GLIB_STATIC_COMPILATION is not defined in your build (see the
> definition of GLIB_VAR in the glib headers).
>
> The pkg-config file for glib doesn't define GLIB_STATIC_COMPILATION for
> pkg-config --static.  I guess we must add it manually.

This seems like a pkg-config config file bug to me.

> Does this work?
>
> diff --git a/configure b/configure
> index 99d8bec..10f23b7 100755
> --- a/configure
> +++ b/configure
> @@ -3047,6 +3047,10 @@ if test "$modules" = yes; then
>      glib_modules="$glib_modules gmodule-2.0"
>  fi
>
> +if test "$static" = yes; then
> +    QEMU_CFLAGS="-DGLIB_STATIC_COMPILATION $QEMU_CFLAGS"
> +fi
> +

I know this is just a "let's see if this works" patch, but
some notes for if this becomes a real patch later:

If we work around this packaging bug in our configure script
we should have a comment stating that it's a workaround for
a packaging bug, and we should probably restrict it to only
being done for Windows builds.

thanks
-- PMM