[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vfio pci: kernel support of error recovery only
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] vfio pci: kernel support of error recovery only for non fatal error |
Date: |
Mon, 20 Mar 2017 16:34:22 +0200 |
On Mon, Mar 20, 2017 at 08:30:56AM -0600, Alex Williamson wrote:
> > > What about the case where the user has not registered for receiving
> > > non-fatal errors, now we send an error signal on both error_detected
> > > and slot_reset. Is that useful/desirable?
> > >
> >
> > Not desirable, but seems not harmful, guest user will stop anyway. How
> > to avoid this case gracefully seems not easy.
>
> "Not harmful" is presuming the behavior of the user. QEMU might not be
> the only consumer of these events. Is it possible to receive a
> slot_reset without first receiving an error_detected? If not then we
> can easily track our action for one to decide on the behavior for the
> other. Thanks,
>
> Alex
I would just pass maximum info to userspace and let it decide.
--
MST