[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/31] ram: move more fields into RAMState
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 01/31] ram: move more fields into RAMState |
Date: |
Mon, 20 Mar 2017 20:36:00 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> last_seen_block, last_sent_block, last_offset, last_version and
>> ram_bulk_stage are globals that are really related together.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> migration/ram.c | 136
>> ++++++++++++++++++++++++++++++++------------------------
>> 1 file changed, 79 insertions(+), 57 deletions(-)
>>
>> diff --git a/migration/ram.c b/migration/ram.c
>> index 719425b..c20a539 100644
>> --- a/migration/ram.c
>> +++ b/migration/ram.c
>> @@ -136,6 +136,23 @@ out:
>> return ret;
>> }
>>
>> +/* State of RAM for migration */
>> +struct RAMState {
>> + /* Last block that we have visited searching for dirty pages */
>> + RAMBlock *last_seen_block;
>> + /* Last block from where we have sent data */
>> + RAMBlock *last_sent_block;
>> + /* Last offeset we have sent data from */
> ^
> One extra e
>
> Other than that (and the minor formatting things the bot found)
fixed, thanks.
>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
- Re: [Qemu-devel] [PATCH 06/31] ram: Move num_dirty_pages_period into RAMState, (continued)
- [Qemu-devel] [PATCH 08/31] ram: Move iterations_prev into RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 04/31] ram: Move start time into RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 01/31] ram: move more fields into RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 07/31] ram: Move xbzrle_cache_miss_prev into RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 10/31] ram: Remove unused dump_mig_dbytes_transferred(), Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 12/31] ram: Move norm_pages to RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 09/31] ram: Move dup_pages into RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 13/31] ram: Remove norm_mig_bytes_transferred, Juan Quintela, 2017/03/15