[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 for-2.9 17/17] qapi: Fix QemuOpts visitor regr
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL v2 for-2.9 17/17] qapi: Fix QemuOpts visitor regression on unvisited input |
Date: |
Wed, 22 Mar 2017 12:57:26 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/22/2017 12:48 PM, Markus Armbruster wrote:
> From: Eric Blake <address@hidden>
>
> An off-by-one in commit 15c2f669e meant that we were failing to
> check for unparsed input in all QemuOpts visitors. Recent testsuite
> additions show that fixing the obvious bug with bogus fields will
> also fix the case of an incomplete list visit; update the tests to
> match the new behavior.
>
> Simple testcase:
>
> ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic -qmp stdio -numa
> node,size=1g
>
> failed to diagnose that 'size' is not a valid argument to -numa, and
> now once again reports:
>
> qemu-system-x86_64: -numa node,size=1g: Invalid parameter 'size'
>
> See also https://bugzilla.redhat.com/show_bug.cgi?id=1434666
>
> CC: address@hidden
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Michael Roth <address@hidden>
> Tested-by: Laurent Vivier <address@hidden>
> Message-Id: <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> [Fixup squashed in]
> Signed-off-by: Markus Armbruster <address@hidden>
Fixup squashed into the wrong patch. End result is the same, though, so
not sure if it is worth a v3 pull request.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL v2 for-2.9 12/17] qapi: Fix string input visitor regression for empty lists, (continued)
- [Qemu-devel] [PULL v2 for-2.9 12/17] qapi: Fix string input visitor regression for empty lists, Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 02/17] keyval: Improve some comments, Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 03/17] test-keyval: Cover alternate and 'any' type, Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 14/17] test-qobject-input-visitor: Cover visit_type_uint64(), Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 08/17] qapi: Drop unused QAPIDoc member optional, Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 01/17] test-keyval: Tweaks to improve list coverage, Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 04/17] keyval: Document issues with 'any' and alternate types, Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 06/17] qapi: Drop excessive Make dependencies on qapi2texi.py, Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 13/17] Revert "hostmem: fix QEMU crash by 'info memdev'", Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 17/17] qapi: Fix QemuOpts visitor regression on unvisited input, Markus Armbruster, 2017/03/22
- Re: [Qemu-devel] [PULL v2 for-2.9 17/17] qapi: Fix QemuOpts visitor regression on unvisited input,
Eric Blake <=
- [Qemu-devel] [PULL v2 for-2.9 16/17] qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts, Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 10/17] tests/qapi-schema: Systematic positive doc comment tests, Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 15/17] tests: Expose regression in QemuOpts visitor, Markus Armbruster, 2017/03/22
- [Qemu-devel] [PULL v2 for-2.9 05/17] MAINTAINERS: Add myself for files I touched recently, Markus Armbruster, 2017/03/22