[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/10] blockjob: strengthen a bit test-blockjob-txn
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 07/10] blockjob: strengthen a bit test-blockjob-txn |
Date: |
Thu, 23 Mar 2017 18:39:25 +0100 |
Unlike test-blockjob-txn, QMP releases the reference to the transaction
before the jobs finish. Thus, while working on the next patch,
qemu-iotest 124 showed a failure that the unit tests did not have.
Make the unit test just a little nastier, so that it fails too.
Signed-off-by: Paolo Bonzini <address@hidden>
---
tests/test-blockjob-txn.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/test-blockjob-txn.c b/tests/test-blockjob-txn.c
index 4ccbda1..bfc2aaa 100644
--- a/tests/test-blockjob-txn.c
+++ b/tests/test-blockjob-txn.c
@@ -165,6 +165,11 @@ static void test_pair_jobs(int expected1, int expected2)
job2 = test_block_job_start(2, true, expected2, &result2);
block_job_txn_add_job(txn, job2);
+ /* Release our reference now to trigger as many nice
+ * use-after-free bugs as possible.
+ */
+ block_job_txn_unref(txn);
+
if (expected1 == -ECANCELED) {
block_job_cancel(job1);
}
@@ -185,8 +190,6 @@ static void test_pair_jobs(int expected1, int expected2)
g_assert_cmpint(result1, ==, expected1);
g_assert_cmpint(result2, ==, expected2);
-
- block_job_txn_unref(txn);
}
static void test_pair_jobs_success(void)
--
2.9.3
- [Qemu-devel] [PATCH for-2.10 00/10] Preparation for block job mutex, Paolo Bonzini, 2017/03/23
- [Qemu-devel] [PATCH 01/10] blockjob: remove unnecessary check, Paolo Bonzini, 2017/03/23
- [Qemu-devel] [PATCH 02/10] blockjob: remove iostatus_reset callback, Paolo Bonzini, 2017/03/23
- [Qemu-devel] [PATCH 03/10] blockjob: introduce block_job_fail, Paolo Bonzini, 2017/03/23
- [Qemu-devel] [PATCH 05/10] blockjob: separate monitor and blockjob APIs, Paolo Bonzini, 2017/03/23
- [Qemu-devel] [PATCH 04/10] blockjob: introduce block_job_pause/resume_all, Paolo Bonzini, 2017/03/23
- [Qemu-devel] [PATCH 06/10] blockjob: move iostatus reset inside block_job_user_resume, Paolo Bonzini, 2017/03/23
- [Qemu-devel] [PATCH 09/10] blockjob: reorganize block_job_completed_txn_abort, Paolo Bonzini, 2017/03/23
- [Qemu-devel] [PATCH 08/10] blockjob: introduce block_job_cancel_async, Paolo Bonzini, 2017/03/23
- [Qemu-devel] [PATCH 07/10] blockjob: strengthen a bit test-blockjob-txn,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 10/10] blockjob: use deferred_to_main_loop to indicate the coroutine has ended, Paolo Bonzini, 2017/03/23