Re: [Qemu-devel] [PATCH RFC v2 5/9] rbd: Don't accept -drive driver=rbd, keyvalue-pairs=...

[Eric Blake]

On 03/24/2017 12:44 PM, Markus Armbruster wrote:
> The way we communicate extra key-value pairs from
> qemu_rbd_parse_filename() to qemu_rbd_open() exposes option parameter
> "keyvalue-pairs" on the command line.  It's not wanted there.  Hack:
> rename the parameter to "=keyvalue-pairs" to make it inaccessible.

We could also use the hack "x-keyvalue-pairs" to make it obvious that it
is unsupported as an external interface (we've used the hack "x-image"
in blkverify/blkdebug), or even "=x-keyvalue-pairs" (combining your hack
with the blkverify hack).  In fact, if your leading '=' hack is nice
enough, we could retrofit blkverify and blkdebug to use it instead of
(or in addition to) the leading "x-" hack.

> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  block/rbd.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature