[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate
From: |
Denis V. Lunev |
Subject: |
[Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate |
Date: |
Mon, 27 Mar 2017 17:38:08 +0300 |
Parallels driver should not call bdrv_truncate if the image was opened
in the read-only mode. Without the patch
qemu-img check harddisk.hds
asserts with
bdrv_truncate: Assertion `child->perm & BLK_PERM_RESIZE' failed.
Parameters used on the write path are not needed if the image is opened
in the read-only mode.
Signed-off-by: Denis V. Lunev <address@hidden>
Reported-by: Edgar Kaziahmedov <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
---
block/parallels.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 6bf9375..4173b3f 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -687,7 +687,8 @@ static int parallels_open(BlockDriverState *bs, QDict
*options, int flags,
if (local_err != NULL) {
goto fail_options;
}
- if (!bdrv_has_zero_init(bs->file->bs) ||
+
+ if (!(flags & BDRV_O_RESIZE) || !bdrv_has_zero_init(bs->file->bs) ||
bdrv_truncate(bs->file, bdrv_getlength(bs->file->bs)) != 0) {
s->prealloc_mode = PRL_PREALLOC_MODE_FALLOCATE;
}
--
2.7.4
- [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate,
Denis V. Lunev <=
- Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate, Stefan Hajnoczi, 2017/03/28
- Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate, Kevin Wolf, 2017/03/28
- Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate, Denis V. Lunev, 2017/03/28
- Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate, Kevin Wolf, 2017/03/29
- Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate, Denis V. Lunev, 2017/03/29
- Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate, Kevin Wolf, 2017/03/29
- Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate, Denis V. Lunev, 2017/03/29
- Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate, Kevin Wolf, 2017/03/29