Re: [Qemu-devel] [PATCH v2] KVM: pci-assign: do not map smm memory slot pages

[Herongguang (Stephen)]

From 8f5b9d2c2944ea7cd8149e9d3b4088f487217d20 Mon Sep 17 00:00:00 2001
From: herongguang <address@hidden>
Date: Mon, 27 Mar 2017 15:08:59 +0800
Subject: [PATCH] KVM: pci-assign: do not map smm memory slot pages in vt-d
 page table

or VM memory are not put thus leaked in kvm_iommu_unmap_memslots() when
destroy VM.

This is consistent with current vfio implementation.

Signed-off-by: herongguang <address@hidden>
---
 virt/kvm/kvm_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 482612b..9018d06 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1052,7 +1052,7 @@ int __kvm_set_memory_region(struct kvm *kvm,
         * changes) is disallowed above, so any other attribute changes getting
         * here can be skipped.
         */
-       if ((change == KVM_MR_CREATE) || (change == KVM_MR_MOVE)) {
+       if ((as_id == 0) && ((change == KVM_MR_CREATE) || (change == 
KVM_MR_MOVE))) {
                r = kvm_iommu_map_pages(kvm, &new);
                return r;
        }
--
1.7.12.4



On 2017/3/27 20:22, Paolo Bonzini wrote:
> On 27/03/2017 09:21, Herongguang (Stephen) wrote:
> >  From f6f0ee6831488bef7af841cb86f3d85a04848fe5 Mon Sep 17 00:00:00 2001
> > From: herongguang <address@hidden>
> > Date: Mon, 27 Mar 2017 15:08:59 +0800
> > Subject: [PATCH] KVM: pci-assign: do not map smm memory slot pages
> >   in vt-d page table
> >
> > or VM memory are not put thus leaked in kvm_iommu_unmap_memslots() when
> > destroy VM.
> >
> > This is consistent with current vfio implementation.
>
> Oops, you forgot a Signed-off-by.
>
> Paolo
>
> > ---
> >   virt/kvm/kvm_main.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> > index 482612b..9018d06 100644
> > --- a/virt/kvm/kvm_main.c
> > +++ b/virt/kvm/kvm_main.c
> > @@ -1052,7 +1052,7 @@ int __kvm_set_memory_region(struct kvm *kvm,
> >        * changes) is disallowed above, so any other attribute changes
> > getting
> >        * here can be skipped.
> >        */
> > -    if ((change == KVM_MR_CREATE) || (change == KVM_MR_MOVE)) {
> > +    if ((as_id == 0) && ((change == KVM_MR_CREATE) || (change ==
> > KVM_MR_MOVE))) {
> >           r = kvm_iommu_map_pages(kvm, &new);
> >           return r;
> >       }
>
> .