Re: [Qemu-devel] [PATCH for-2.9] configure: Don't claim 'unsupported host OS' when better message available

[Peter Maydell]

On 28 March 2017 at 14:18, Peter Maydell <address@hidden> wrote:
> The change in commit 898be3e0415c6d which made completely
> unrecognized OSes cause an error_exit "Unsupported host OS"
> has some unfortunate unintended effects:
>  * if you run 'configure --help' on an unsupported host OS
>    (eg if intending to use it as a build machine for a
>    cross compile to a supported host) then the message
>    is printed instead of --help
>  * if the C compiler doesn't work or is missing (eg if
>    you passed an incorrect --cross-prefix by mistake)
>    the message is printed instead of the more useful
>    'compiler does not exist or does not work' message
>
> Fix this by postponing the error_exit in this situation
> until later, when we have already identified the more
> useful cases for this.

> +if test "$bogus_os" = "yes"; then
> +    # Now that we know that we're not printing the help and that
> +    # the compiler works (so the results of the check_defines we used
> +    # to identify the OS are reliable), if we didn't recognize the
> +    # host OS we should stop now.
> +    error_exit "Unsupported host OS $targetos"
> +fi

Oops, I just noticed I had a minor change here which I forgot
to squash in before sending:

-    error_exit "Unsupported host OS $targetos"
+    error_exit "Unrecognized host OS $targetos"

since this is the case of "we don't know what this is" rather
than "we know what this is but we're planning to remove it".

OK to squash that in when I apply this patch?

thanks
-- PMM