[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] hmp: info migrate_capability format tunes
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] hmp: info migrate_capability format tunes |
Date: |
Fri, 31 Mar 2017 20:01:36 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
* Peter Xu (address@hidden) wrote:
> Dump the info in a single line is hard to read. Do it one per line.
> Also, the first "capabilities:" didn't help much. Let's remove it.
>
> CC: "Dr. David Alan Gilbert" <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
agreed, although you may find it breaks some peoples scripts, but
we're allowed to do that in HMP and it should be more readable, so:
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hmp.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hmp.c b/hmp.c
> index edb8970..95eef8c 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -265,13 +265,11 @@ void hmp_info_migrate_capabilities(Monitor *mon, const
> QDict *qdict)
> caps = qmp_query_migrate_capabilities(NULL);
>
> if (caps) {
> - monitor_printf(mon, "capabilities: ");
> for (cap = caps; cap; cap = cap->next) {
> - monitor_printf(mon, "%s: %s ",
> + monitor_printf(mon, "%s: %s\n",
>
> MigrationCapability_lookup[cap->value->capability],
> cap->value->state ? "on" : "off");
> }
> - monitor_printf(mon, "\n");
> }
>
> qapi_free_MigrationCapabilityStatusList(caps);
> --
> 2.7.4
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 0/5] several migrations related patches, Peter Xu, 2017/03/27
- [Qemu-devel] [PATCH 1/5] migration: set current_active_state once, Peter Xu, 2017/03/27
- [Qemu-devel] [PATCH 2/5] migration: rename max_size to threshold_size, Peter Xu, 2017/03/27
- [Qemu-devel] [PATCH 3/5] hmp: info migrate_capability format tunes, Peter Xu, 2017/03/27
- Re: [Qemu-devel] [PATCH 3/5] hmp: info migrate_capability format tunes,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 4/5] hmp: info migrate_parameters format tunes, Peter Xu, 2017/03/27
- [Qemu-devel] [PATCH 5/5] cpu: throttle: fix throttle time slice, Peter Xu, 2017/03/27