Re: [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag

[Philippe Mathieu-Daudé]

On 03/31/2017 09:46 PM, Eduardo Habkost wrote:
> unimplemented-device needs to be created and mapped using
> create_unimplemented_device(), and won't work with -device.
> Remove the user_creatable flag from the device class.
>
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  hw/misc/unimp.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c
> index 284f096beb..bcbb585888 100644
> --- a/hw/misc/unimp.c
> +++ b/hw/misc/unimp.c
> @@ -90,11 +90,6 @@ static void unimp_class_init(ObjectClass *klass, void *data)
>
>      dc->realize = unimp_realize;
>      dc->props = unimp_properties;
> -    /*
> -     * FIXME: Set only for compatibility on q35 machine-type.
> -     * Probably never meant to be user-creatable
> -     */
> -    dc->user_creatable = true;
>  }
>
>  static const TypeInfo unimp_info = {