[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] vhost: simple clean up
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] vhost: simple clean up |
|
Date: |
Fri, 7 Apr 2017 08:51:10 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/07/2017 03:38 AM, Sahid Orentino Ferdjaoui wrote:
> On Fri, Apr 07, 2017 at 02:58:46PM +0800, weiqi wrote:
>> From: Wei Qi <address@hidden>
>>
>> It is unnecessary to assign 'hdev->nvqs' to 'i', because 'hdev->nvqs' unused
>> after assignment, so remove it.
>
> nit: The line should not be longer than 76 characters [0].
>
> [0]
> http://wiki.qemu-project.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message
Also, make sure you have proper threading. Although you sent a 0/3
cover letter (with Message-ID:
<address@hidden>), this 1/3 message
is lacking both References: and In-Reply-To: headers, and therefore
appears as its own top level thread.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature