[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/10] blockjob: remove iostatus_reset callback
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH 02/10] blockjob: remove iostatus_reset callback |
Date: |
Fri, 7 Apr 2017 19:12:42 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/23/2017 01:39 PM, Paolo Bonzini wrote:
> This is unused since commit 66a0fae ("blockjob: Don't touch BDS iostatus",
> 2016-05-19).
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> blockjob.c | 3 ---
> include/block/blockjob_int.h | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/blockjob.c b/blockjob.c
> index a9fb624..24d1e12 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -555,9 +555,6 @@ bool block_job_is_cancelled(BlockJob *job)
> void block_job_iostatus_reset(BlockJob *job)
> {
> job->iostatus = BLOCK_DEVICE_IO_STATUS_OK;
> - if (job->driver->iostatus_reset) {
> - job->driver->iostatus_reset(job);
> - }
> }
>
> static int block_job_finish_sync(BlockJob *job,
> diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h
> index 3f86cc5..bfcc5d1 100644
> --- a/include/block/blockjob_int.h
> +++ b/include/block/blockjob_int.h
> @@ -44,9 +44,6 @@ struct BlockJobDriver {
> /** Optional callback for job types that support setting a speed limit */
> void (*set_speed)(BlockJob *job, int64_t speed, Error **errp);
>
> - /** Optional callback for job types that need to forward I/O status
> reset */
> - void (*iostatus_reset)(BlockJob *job);
> -
> /** Mandatory: Entrypoint for the Coroutine. */
> CoroutineEntry *start;
>
>
Good find.
Reviewed-by: John Snow <address@hidden>
- Re: [Qemu-devel] [PATCH 02/10] blockjob: remove iostatus_reset callback,
John Snow <=