[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/arm: Add assertion about FSC format for
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] target/arm: Add assertion about FSC format for syndrome registers |
Date: |
Mon, 10 Apr 2017 09:57:50 +0100 |
On 10 April 2017 at 09:44, Edgar E. Iglesias <address@hidden> wrote:
> Have you seen something suspicous when running code or was
> this a theoretical issue?
No, I was looking at the code for a different reason and
was surprised that the syndrome-generation code wasn't doing
anything to handle short-format FSRs. I started out thinking
that this was just a corner case we'd forgotten since it
only affects AArch32 guests (and even wrote some code to do
short-to-long status code conversion), but after some thought
I realised that it's not possible to get to a point where
we would need the syndrome after such a fault. It's a
tricky enough point that it seems worth having an assert
and some comments to assure future readers that it isn't
just something we forgot to handle...
thanks
-- PMM