[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] blockjob: separate monitor and blockjob A
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH 05/10] blockjob: separate monitor and blockjob APIs |
|
Date: |
Mon, 10 Apr 2017 12:05:53 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/08/2017 05:52 AM, Paolo Bonzini wrote:
>
>
> On 08/04/2017 08:03, John Snow wrote:
>> Looks clean, though it may be useful to do a few more things;
>>
>> - Demarcate what you think is the monitor API in this file
>
> It's already there:
>
> +/*
> + * API for block job drivers and the block layer.
> + */
> +
>
> where everything before is for the monitor.
>
I meant explicitly, with a comment at the top explaining the demarcation.
>> - Organize blockjob.h to match to serve as a useful reference.
>
> Hmm, yes.
>
> Paolo
>