[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 8/9] qemu-iotests: support per-format golden
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v4 8/9] qemu-iotests: support per-format golden output files |
Date: |
Tue, 11 Apr 2017 13:25:56 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 05 Apr 2017 05:11:47 PM CEST, Stefan Hajnoczi wrote:
> Some tests produce format-dependent output. Either the difference is
> filtered out and ignored, or the test case is format-specific so we
> don't need to worry about per-format output differences.
>
> There is a third case: the test script is the same for all image formats
> and the format-dependent output is relevant. An ugly workaround is to
> copy-paste the test into multiple per-format test cases. This
> duplicates code and is not maintainable.
>
> This patch allows test cases to add per-format golden output files so a
> single test case can work correctly when format-dependent output must be
> checked:
>
> 123.out.qcow2
> 123.out.raw
> 123.out.vmdk
> ...
>
> This naming scheme is not composable with 123.out.nocache or 123.pc.out,
> two other scenarios where output files are split. I don't think it
> matters since few test cases need these features.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- [Qemu-devel] [PATCH v4 2/9] raw-format: add bdrv_measure() support, (continued)
- [Qemu-devel] [PATCH v4 2/9] raw-format: add bdrv_measure() support, Stefan Hajnoczi, 2017/04/05
- [Qemu-devel] [PATCH v4 3/9] qcow2: extract preallocation calculation function, Stefan Hajnoczi, 2017/04/05
- [Qemu-devel] [PATCH v4 4/9] qcow2: make refcount size calculation conservative, Stefan Hajnoczi, 2017/04/05
- [Qemu-devel] [PATCH v4 5/9] qcow2: extract image creation option parsing, Stefan Hajnoczi, 2017/04/05
- [Qemu-devel] [PATCH v4 6/9] qcow2: add bdrv_measure() support, Stefan Hajnoczi, 2017/04/05
- [Qemu-devel] [PATCH v4 7/9] qemu-img: add measure subcommand, Stefan Hajnoczi, 2017/04/05
- [Qemu-devel] [PATCH v4 8/9] qemu-iotests: support per-format golden output files, Stefan Hajnoczi, 2017/04/05
- Re: [Qemu-devel] [PATCH v4 8/9] qemu-iotests: support per-format golden output files,
Alberto Garcia <=
- [Qemu-devel] [PATCH v4 9/9] iotests: add test 178 for qemu-img measure, Stefan Hajnoczi, 2017/04/05