[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name
Date: Tue, 11 Apr 2017 08:02:04 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 02/17/2017 08:05 AM, Fam Zheng wrote:
> On Fri, 02/17 16:36, Vladimir Sementsov-Ogievskiy wrote:
>> 17.02.2017 15:21, Fam Zheng wrote:
>>> On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote:
>>>> 16.02.2017 16:48, Fam Zheng wrote:
>>>>> On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote:
>>>>>> When testing migration, auto-generated by qemu node-names differs in
>>>>>> source and destination qemu and migration fails. After this patch,
>>>>>> auto-generated by iotest nodenames will be the same.
>>>>> What should be done in libvirt to make sure the node-names are matching
>>>>> correctly at both sides?
>>>> Hmm, just set node names appropriately?
>>> But I think the problem is that node names are not configurable from libvirt
>>> today, and then the migration will fail. Should the device name take 
>>> precedence
>>> in the code, to make it easier?
>> libvirt can use same parameters as I in this patch..
> If I'm not mistaken, libvirt can be patched to explicitly set the same node
> names in the QEMU command line, but that is some extra work to do there. My
> point is if device names are used during migration, when available, this patch
> and the libvirt change is not necessary.

Ultimately, libvirt will be taught to use node names everywhere, at
which point the appearance of an autogenerated node name in a qemu
managed by libvirt will be considered a libvirt bug.  We're not there
yet, but don't let auto-generated node names hold up a series.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]