[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Changed malloc and free to g_malloc and g_free
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] Changed malloc and free to g_malloc and g_free in util/envlist.c |
|
Date: |
Tue, 11 Apr 2017 16:34:57 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/11/2017 04:30 PM, Eric Blake wrote:
> You're also missing a category, and patches should generally favor
> imperative tense (think "[apply this patch to] do this") rather than
> past tense ("[this patch] did this"). Also, you want the subject line
> to be a short how; the commit body can be used for further explanations.
I hit send too soon; I was trying to say:
the subject line is a short "what"; the commit body goes into "why" or
more details "how" as needed.
At any rate, these suggestions, and more, can be found at:
http://wiki.qemu-project.org/Contribute/SubmitAPatch
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature