qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tests/check-qdict: Fix missing brackets


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] tests/check-qdict: Fix missing brackets
Date: Wed, 12 Apr 2017 11:04:26 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

"Dr. David Alan Gilbert (git)" <address@hidden> writes:

> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Gcc 7 (on Fedora 26) spotted odd use of integers instead of a
> boolean; it's got a point.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  tests/check-qdict.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/check-qdict.c b/tests/check-qdict.c
> index 81162ee572..6f3fbcf9c1 100644
> --- a/tests/check-qdict.c
> +++ b/tests/check-qdict.c
> @@ -559,7 +559,7 @@ static void qdict_join_test(void)
>          g_assert(qdict_size(dict1) == 2);
>          g_assert(qdict_size(dict2) == !overwrite);
>  
> -        g_assert(qdict_get_int(dict1, "foo") == overwrite ? 84 : 42);
> +        g_assert(qdict_get_int(dict1, "foo") == (overwrite ? 84 : 42));
>          g_assert(qdict_get_int(dict1, "bar") == 23);
>  
>          if (!overwrite) {

Reviewed-by: Markus Armbruster <address@hidden>

Applied to qapi-next, thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]