[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/19] migration: Create block capabilities for
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 09/19] migration: Create block capabilities for shared and enable |
Date: |
Tue, 18 Apr 2017 08:35:42 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Blake <address@hidden> wrote:
> On 04/17/2017 03:00 PM, Juan Quintela wrote:
>> This two capabilites were added through the command line. Notice that
>
> s/This/These/
> s/capabilites/capabilities/
>
>> we just created them. This is just the boilerplate.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> include/migration/migration.h | 3 +++
>> migration/migration.c | 36 ++++++++++++++++++++++++++++++++++++
>> qapi-schema.json | 7 ++++++-
>> 3 files changed, 45 insertions(+), 1 deletion(-)
>
> I think this is a nice cleanup, even if it is exposing the internal
> block migration (the 'migrate -b' stuff) that we really don't like (it
> is one of the things causing grief at the 2.9-rc4 stage), because users
> should be favoring NBD migration over internal block migration these days.
I am 1st in the queue to remove it, but each time that we talk about
removing it, somebody appears to came to fix it :-p
So, if it has to stay, just update it with the times.
> Reviewed-by: Eric Blake <address@hidden>
- [Qemu-devel] [PATCH 04/19] migration: Remove MigrationState from migration_channel_incomming(), (continued)
- [Qemu-devel] [PATCH 04/19] migration: Remove MigrationState from migration_channel_incomming(), Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 05/19] migration: Export exec.c functions in its own file, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 06/19] migration: Export fd.c functions in its own file, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 07/19] migration: Export socket.c functions in its own file, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 08/19] migration: Export tls.c functions in its own file, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 09/19] migration: Create block capabilities for shared and enable, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 10/19] migration: Remove use of old MigrationParams, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 13/19] migration: Remove qemu-file.h from vmstate.h, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 11/19] migration: Remove old MigrationParams, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 14/19] migration: Remove vmstate.h from migration.h, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 12/19] migration: Remove unneeded includes, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 15/19] migration: Export qemu-file-channel.c functions in its own file, Juan Quintela, 2017/04/17