Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt: generate 64-bit addressable ACPI objects

[Peter Maydell]

On 10 April 2017 at 16:03, Ard Biesheuvel <address@hidden> wrote:
> Our current ACPI table generation code limits the placement of ACPI
> tables to 32-bit addressable memory, in order to be able to emit the
> root pointer (RSDP) and root table (RSDT) using table types from the
> ACPI 1.0 days.
>
> Since ARM was not supported by ACPI before version 5.0, it makes sense
> to lift this restriction. This is not crucial for mach-virt, which is
> guaranteed to have some memory available below the 4 GB mark, but it
> is a nice to have for QEMU machines that do not have any 32-bit
> addressable memory, which is not uncommon for real world 64-bit ARM
> systems.
>
> Since we already emit a version of the RSDP root pointer that has a
> secondary 64-bit wide address field for the 64-bit root table (XSDT),
> all we need to do is replace the RSDT generation with the generation
> of an XSDT table, and use a different slot in the FADT table to refer
> to the DSDT.
>
> Signed-off-by: Ard Biesheuvel <address@hidden>
> Reviewed-by: Andrew Jones <address@hidden>
> Acked-by: Laszlo Ersek <address@hidden>

Michael -- I'm assuming you're planning to take these 2 patches
via the ACPI tree; let me know if you'd rather I take them via
the ARM tree.

Acked-by: Peter Maydell <address@hidden>

thanks
-- PMM