[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/15] hw/core/null-machine: Print error message when
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 11/15] hw/core/null-machine: Print error message when using the -kernel parameter |
Date: |
Thu, 20 Apr 2017 15:47:01 -0300 |
From: Thomas Huth <address@hidden>
If the user currently tries to use the -kernel parameter, simply nothing
happens, and the user might get confused that there is nothing loaded
to memory, but also no error message has been issued. Since there is no
real generic way to load a kernel on all CPU types (but on some targets,
the generic loader can be used instead), issue an appropriate error
message here now to avoid the possible confusion.
Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/core/null-machine.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c
index 27c8369b57..864832db34 100644
--- a/hw/core/null-machine.c
+++ b/hw/core/null-machine.c
@@ -40,6 +40,12 @@ static void machine_none_init(MachineState *mch)
memory_region_allocate_system_memory(ram, NULL, "ram", mch->ram_size);
memory_region_add_subregion(get_system_memory(), 0, ram);
}
+
+ if (mch->kernel_filename) {
+ error_report("The -kernel parameter is not supported "
+ "(use the generic 'loader' device instead).");
+ exit(1);
+ }
}
static void machine_none_machine_init(MachineClass *mc)
--
2.11.0.259.g40922b1
- [Qemu-devel] [PULL 02/15] memory: provide IOMMU_NOTIFIER_FOREACH macro, (continued)
- [Qemu-devel] [PULL 02/15] memory: provide IOMMU_NOTIFIER_FOREACH macro, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 01/15] memory: add section range info for IOMMU notifier, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 03/15] memory: provide iommu_replay_all(), Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 04/15] memory: introduce memory_region_notify_one(), Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 05/15] memory: add MemoryRegionIOMMUOps.replay() callback, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 06/15] intel_iommu: use the correct memory region for device IOTLB notification, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 07/15] intel_iommu: provide its own replay() callback, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 08/15] intel_iommu: allow dynamic switch of IOMMU region, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 10/15] qdev: Make "hotplugged" property read-only, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 09/15] intel_iommu: enable remote IOTLB, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 11/15] hw/core/null-machine: Print error message when using the -kernel parameter,
Eduardo Habkost <=
- [Qemu-devel] [PULL 12/15] hostmem: introduce host_memory_backend_mr_inited(), Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 13/15] hostmem: use host_memory_backend_mr_inited() where proper, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 14/15] qdev: Constify value passed to qdev_prop_set_macaddr, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 15/15] qdev: Constify local variable returned by blk_bs, Eduardo Habkost, 2017/04/20
- Re: [Qemu-devel] [PULL 00/15] Machine queue for 2.10, Peter Maydell, 2017/04/21