[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of f
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions |
Date: |
Mon, 24 Apr 2017 10:27:05 +0100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Mon, Apr 24, 2017 at 11:24:31AM +0200, Markus Armbruster wrote:
> Fam Zheng <address@hidden> writes:
>
> > On Mon, 04/24 09:28, Daniel P. Berrange wrote:
> >> On Fri, Apr 21, 2017 at 08:27:02PM +0800, Fam Zheng wrote:
> >> > Move opaque to 2nd instead of the 2nd to last, so that compilers help
> >> > check with the convertion.
> >>
> >> Moving 'opaque' like this should not be done.
> >>
> >> If you want the compiler to check the fixes, it should be done in
> >> just two stages. First move errp & move opaque to start, compile
> >> it & verify. Then put opaque back to where it was, and compile
> >> again. The resulting commit thus only has the errp move, not the
> >> unrelated & uneccessary opaque move.
> >
> > The idea is to let everyone's compiler verifies this patch, and also to
> > avoid
> > possible bugs introduced in backporting/rebasing/merging - for example if a
> > patch in another tree addes one more implementation that uses the old
> > order, we
> > can notice.
That is true in general, but in reality this particular function is not
widely used and so chance of there being another out of tree impl is
essentially zero.
> >
> > If you don't like this, we can be careful and don't move opaque; or after a
> > short while, move opaque back in a separate commit (since Markus already
> > sent a
> > pull request).
>
> I'm prepared to NAK my pull request if we think we need more time to
> discuss the patches.
It isn't a big deal either way. I can just send a follow up patch if needed
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH 01/14] socket: Make errp the last parameter of socket_connect, (continued)
- [Qemu-devel] [PATCH 01/14] socket: Make errp the last parameter of socket_connect, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 02/14] socket: Make errp the last parameter of inet_connect_saddr, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 03/14] socket: Make errp the last parameter of unix_connect_saddr, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 04/14] socket: Make errp the last parameter of vsock_connect_saddr, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 05/14] block: Make errp the last parameter of bdrv_img_create, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions, Fam Zheng, 2017/04/21
[Qemu-devel] [PATCH 07/14] mirror: Make errp the last parameter of mirror_start_job, Fam Zheng, 2017/04/21
[Qemu-devel] [PATCH 08/14] block: Make errp the last parameter of commit_active_start, Fam Zheng, 2017/04/21
[Qemu-devel] [PATCH 09/14] nfs: Make errp the last parameter of nfs_client_open, Fam Zheng, 2017/04/21
[Qemu-devel] [PATCH 11/14] scsi: Make errp the last parameter of virtio_scsi_common_realize, Fam Zheng, 2017/04/21
[Qemu-devel] [PATCH 10/14] fdc: Make errp the last parameter of fdctrl_connect_drives, Fam Zheng, 2017/04/21
[Qemu-devel] [PATCH 12/14] migration: Make errp the last parameter of local functions, Fam Zheng, 2017/04/21
[Qemu-devel] [PATCH 13/14] qga: Make errp the last parameter of qga_vss_fsfreeze, Fam Zheng, 2017/04/21
[Qemu-devel] [PATCH 14/14] error: Apply error_propagate_null.cocci again, Fam Zheng, 2017/04/21
Re: [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting, Eric Blake, 2017/04/21
Re: [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting, Markus Armbruster, 2017/04/22