[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10 |
Date: |
Mon, 24 Apr 2017 22:46:07 +0100 |
On 24 April 2017 at 22:25, Stefano Stabellini <address@hidden> wrote:
> diff --git a/hw/9pfs/xen-9pfs.h b/hw/9pfs/xen-9pfs.h
> new file mode 100644
> index 0000000..18f0ec0
> --- /dev/null
> +++ b/hw/9pfs/xen-9pfs.h
> @@ -0,0 +1,14 @@
> +/*
> + * Xen 9p backend
> + *
> + * Copyright Aporeto 2017
> + *
> + * Authors:
> + * Stefano Stabellini <address@hidden>
> + *
> + */
Trivial file, but I prefer it if we have a brief license
statement in every file, just to be clear (it might
accumulate more code later).
> +
> +#include <xen/io/protocols.h>
> +#include "hw/xen/io/ring.h"
> +
> +DEFINE_XEN_FLEX_RING_AND_INTF(xen_9pfs);
Is it worth a comment to dissuade people from thinking they can
inline the file back into xen-9p-backend.c ?
thanks
-- PMM
- [Qemu-devel] [PULL 14/21] xen/9pfs: receive requests from the frontend, (continued)
- [Qemu-devel] [PULL 14/21] xen/9pfs: receive requests from the frontend, Stefano Stabellini, 2017/04/21
- [Qemu-devel] [PULL 16/21] xen/9pfs: send responses back to the frontend, Stefano Stabellini, 2017/04/21
- [Qemu-devel] [PULL 15/21] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal, Stefano Stabellini, 2017/04/21
- [Qemu-devel] [PULL 17/21] xen/9pfs: build and register Xen 9pfs backend, Stefano Stabellini, 2017/04/21
- [Qemu-devel] [PULL 18/21] add xen-9p-backend to MAINTAINERS under Xen, Stefano Stabellini, 2017/04/21
- [Qemu-devel] [PULL 19/21] move xen-common.c to hw/xen/, Stefano Stabellini, 2017/04/21
- [Qemu-devel] [PULL 21/21] move xen-mapcache.c to hw/i386/xen/, Stefano Stabellini, 2017/04/21
- [Qemu-devel] [PULL 20/21] move xen-hvm.c to hw/i386/xen/, Stefano Stabellini, 2017/04/21
- Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10, Peter Maydell, 2017/04/24
- Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10, Stefano Stabellini, 2017/04/24
- Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10,
Peter Maydell <=
- Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10, Stefano Stabellini, 2017/04/24
- Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10, Greg Kurz, 2017/04/25
- Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10, Markus Armbruster, 2017/04/25
- Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10, Stefano Stabellini, 2017/04/25
- Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10, Markus Armbruster, 2017/04/26