[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] crypto: move 'opaque' parameter to (nearly) the
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH] crypto: move 'opaque' parameter to (nearly) the end of parameter list |
|
Date: |
Tue, 25 Apr 2017 10:06:18 +0100 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Tue, Apr 25, 2017 at 09:30:13AM +0200, Markus Armbruster wrote:
> "Daniel P. Berrange" <address@hidden> writes:
>
> > Previous commit moved 'opaque' to be the 2nd parameter in the list:
> >
> > commit 375092332eeaa6e47561ce47fd36144cdaf964d0
> > Author: Fam Zheng <address@hidden>
> > Date: Fri Apr 21 20:27:02 2017 +0800
> >
> > crypto: Make errp the last parameter of functions
> >
> > Move opaque to 2nd instead of the 2nd to last, so that compilers help
> > check with the conversion.
> >
> > this puts it back to the 2nd to last position.
> >
> > Signed-off-by: Daniel P. Berrange <address@hidden>
>
> I could take this through my tree, but I suggest you stick it into your
> next crypto pull request.
Yes, I'll submit it myself as I have a bunch of other stuff pending.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|