[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] input: don't queue delay if paused

From: Marc-André Lureau
Subject: [Qemu-devel] [PATCH] input: don't queue delay if paused
Date: Tue, 25 Apr 2017 17:05:20 +0400

qemu_input_event_send() discards key event when the guest is paused,
but not the delay.

The delay ends up in the input queue, and qemu_input_event_send_key()
will further fill the queue with upcoming events.

VNC uses qemu_input_event_send_key_delay(), not SPICE, which results
in a different input behaviour on pause: VNC will queue the events
(except the first that is discarded), SPICE will discard all events.

Don't queue delay if paused, and provide same behaviour on SPICE and
VNC clients on resume (and potentially avoid over-allocating the
buffer queue)


Signed-off-by: Marc-André Lureau <address@hidden>
 ui/input.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ui/input.c b/ui/input.c
index ed88cda6d6..383158b65b 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -405,6 +405,10 @@ void qemu_input_event_send_key_qcode(QemuConsole *src, 
QKeyCode q, bool down)
 void qemu_input_event_send_key_delay(uint32_t delay_ms)
+    if (!runstate_is_running() && !runstate_check(RUN_STATE_SUSPENDED)) {
+        return;
+    }
     if (!kbd_timer) {
         kbd_timer = timer_new_ms(QEMU_CLOCK_VIRTUAL, qemu_input_queue_process,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]