Re: [Qemu-devel] [PULL 0/8] qemu-ga patch queue

[Peter Maydell]

On 26 April 2017 at 00:04, Michael Roth <address@hidden> wrote:
> The following changes since commit fe491fa85c4634453b340b18046aae2eaf8147db:
>
>   Merge remote-tracking branch 'remotes/agraf/tags/signed-s390-for-upstream' 
> into staging (2017-04-25 14:48:55 +0100)
>
> are available in the git repository at:
>
>   git://github.com/mdroth/qemu.git tags/qga-pull-2017-04-25-tag
>
> for you to fetch changes up to b3734da00e4285521f8eb2c958ab08b981f7a298:
>
>   qga: Add `guest-get-timezone` command (2017-04-25 15:49:24 -0500)
>
> ----------------------------------------------------------------
> qemu-ga patch queue
>
> * new commands: guest-get-timezone, guest-get-users, guest-get-host-name
> * fix hang on w32 when stopping qemu-ga service while fs frozen
> * fix missing setting of can-offline in guest-get-vcpus
> * make qemu-ga VSS w32 service on-demand rather than on-startup
> * fix unecessary errors to EventLog on w32
> * improvements to fsfreeze documentation
>

Hi. I'm afraid this doesn't build with clang:

In file included from
/Users/pm215/src/qemu-for-merges/qapi/qapi-dealloc-visitor.c:15:
In file included from /Users/pm215/src/qemu-for-merges/include/qemu/osdep.h:107:
/Users/pm215/src/qemu-for-merges/include/glib-compat.h:221:17: error:
unused function 'g_hash_table_contains' [-Werror,-Wunused-function]
static gboolean g_hash_table_contains(GHashTable *hash_table, gpointer key)
                ^
1 error generated.

Marking it "static inline" should fix this.

thanks
-- PMM