[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 02/18] block: add ability to set a prefix for
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 02/18] block: add ability to set a prefix for opt names |
Date: |
Wed, 26 Apr 2017 08:28:04 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 04/25/2017 10:38 AM, Daniel P. Berrange wrote:
> When integrating the crypto support with qcow/qcow2, we don't
> want to use the bare LUKS option names "hash-alg", "key-secret",
> etc. We want to namespace them "luks-hash-alg", "luks-key-secret"
> so that they don't clash with any general qcow options at a later
> date.
>
> Reviewed-by: Max Reitz <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> block/crypto.c | 16 ++++++++--------
> block/crypto.h | 40 ++++++++++++++++++++--------------------
> 2 files changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/block/crypto.c b/block/crypto.c
> index 8205bd8..7edcc49 100644
> --- a/block/crypto.c
> +++ b/block/crypto.c
> @@ -129,7 +129,7 @@ static QemuOptsList block_crypto_runtime_opts_luks = {
> .name = "crypto",
> .head = QTAILQ_HEAD_INITIALIZER(block_crypto_runtime_opts_luks.head),
> .desc = {
> - BLOCK_CRYPTO_OPT_DEF_LUKS_KEY_SECRET,
> + BLOCK_CRYPTO_OPT_DEF_LUKS_KEY_SECRET(""),
Is this still needed, given your cover letter said you reworked things
to use a nested struct? I'm still not convinced we need the complexity
of two different prefixes if we can instead reuse a common structure.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v6 03/18] qcow: document another weakness of qcow AES encryption, Daniel P. Berrange, 2017/04/25
[Qemu-devel] [PATCH v6 01/18] block: expose crypto option names / defs to other drivers, Daniel P. Berrange, 2017/04/25
[Qemu-devel] [PATCH v6 04/18] qcow: require image size to be > 1 for new images, Daniel P. Berrange, 2017/04/25
[Qemu-devel] [PATCH v6 06/18] iotests: skip 048 with qcow which doesn't support resize, Daniel P. Berrange, 2017/04/25
[Qemu-devel] [PATCH v6 05/18] iotests: skip 042 with qcow which dosn't support zero sized images, Daniel P. Berrange, 2017/04/25
[Qemu-devel] [PATCH v6 08/18] qcow: make encrypt_sectors encrypt in place, Daniel P. Berrange, 2017/04/25