[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scala
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros |
Date: |
Fri, 28 Apr 2017 10:33:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> We now have macros in place to make it less verbose to add a scalar
> to QDict and QList, so use them. To make this patch smaller to
> review, a couple of subdirectories were done in earlier patches.
Scratch the last sentence. Can do on commit.
> Patch created mechanically via:
> spatch --sp-file scripts/coccinelle/qobject.cocci \
> --macro-file scripts/cocci-macro-file.h --dir . --in-place
> then touched up manually to fix a couple of '?:' back to original
> spacing, as well as avoiding a long line in monitor.c.
>
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
>
> ---
> v5: rebase to master (Coccinelle found a couple new spots), squash 3
> patches into 1, adjust R-b to only list Markus (while there were other
> reviews on the pre-squashed patches, Markus was the only one on all 3)
The block: part had
Acked-by: Richard W.M. Jones <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
The tests and qobject parts had
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Richard, Stefan, Alberto, Philippe, let me know if you'd like me to
convert your R-by of parts to an Acked-by of the combined patch. Feel
free to review the combined patch, of course.
> v4: no change
> v3: new patch
- [Qemu-devel] [PATCH v5 01/10] pci: Use struct instead of QDict to pass back parameters, (continued)
- [Qemu-devel] [PATCH v5 01/10] pci: Use struct instead of QDict to pass back parameters, Eric Blake, 2017/04/27
- [Qemu-devel] [PATCH v5 02/10] pci: Reduce scope of error injection, Eric Blake, 2017/04/27
- [Qemu-devel] [PATCH v5 03/10] coccinelle: Add script to remove useless QObject casts, Eric Blake, 2017/04/27
- [Qemu-devel] [PATCH v5 05/10] qobject: Add helper macros for common scalar insertions, Eric Blake, 2017/04/27
- [Qemu-devel] [PATCH v5 04/10] qobject: Drop useless QObject casts, Eric Blake, 2017/04/27
- [Qemu-devel] [PATCH v5 08/10] QemuOpts: Simplify qemu_opts_to_qdict(), Eric Blake, 2017/04/27
- [Qemu-devel] [PATCH v5 07/10] block: Simplify bdrv_append_temp_snapshot() logic, Eric Blake, 2017/04/27
- [Qemu-devel] [PATCH v5 09/10] fdc-test: Avoid deprecated 'change' command, Eric Blake, 2017/04/27
- [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes, Eric Blake, 2017/04/27
- [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros, Eric Blake, 2017/04/27
- Re: [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros,
Markus Armbruster <=