[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] audio: release capture buffers
From: |
P J P |
Subject: |
Re: [Qemu-devel] [PATCH] audio: release capture buffers |
Date: |
Fri, 28 Apr 2017 14:21:56 +0530 (IST) |
+-- On Fri, 28 Apr 2017, Gerd Hoffmann wrote --+
| AUD_add_capture() allocates two buffers which get never released.
which get never -> which are never ...
| Impact: Allows vnc clients to exhaust host memory by repeatly
repeatly -> repeatedly
| diff --git a/audio/audio.c b/audio/audio.c
| index c8898d8422..beafed209b 100644
| --- a/audio/audio.c
| +++ b/audio/audio.c
| @@ -2028,6 +2028,8 @@ void AUD_del_capture (CaptureVoiceOut *cap, void
*cb_opaque)
| sw = sw1;
| }
| QLIST_REMOVE (cap, entries);
| + g_free (cap->hw.mix_buf);
| + g_free (cap->buf);
| g_free (cap);
| }
| return;
Looks okay.
Reviewed-by: Prasad J Pandit <address@hidden>
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F