[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 03/19] qemu/atomic: Loosen restrictions for 6
|
From: |
Alex Bennée |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 03/19] qemu/atomic: Loosen restrictions for 64-bit ILP32 hosts |
|
Date: |
Fri, 28 Apr 2017 11:25:30 +0100 |
|
User-agent: |
mu4e 0.9.19; emacs 25.2.17 |
Richard Henderson <address@hidden> writes:
> On 04/28/2017 09:47 AM, Alex Bennée wrote:
>> So maybe the comment should be clearer for ATOMIC_REG_SIZE that it
>> should match TCG_TARGET_REG_BITS (and therefore sync with
>> TCG_OVERSIZED_GUEST) in the atomic.h comment.
>
> How about
>
> * That said, we have a problem on 64-bit ILP32 hosts in that in order to
> * sync with TCG_OVERSIZED_GUEST, this must match TCG_TARGET_REG_BITS.
> * We'd prefer not want to pull in everything else TCG related, so handle
> * those few cases by hand.
>
> ?
Sounds good to me.
Reviewed-by: Alex Bennée <address@hidden>
--
Alex Bennée
- [Qemu-devel] [PATCH v5 01/19] target/nios2: Fix 64-bit ilp32 compilation, (continued)
[Qemu-devel] [PATCH v5 06/19] tcg: introduce goto_ptr opcode, Richard Henderson, 2017/04/27
[Qemu-devel] [PATCH v5 10/19] target/i386: introduce gen_jr helper to generate lookup_and_goto_ptr, Richard Henderson, 2017/04/27
[Qemu-devel] [PATCH v5 11/19] target/i386: optimize cross-page direct jumps in softmmu, Richard Henderson, 2017/04/27
[Qemu-devel] [PATCH v5 09/19] target/arm: optimize indirect branches, Richard Henderson, 2017/04/27
[Qemu-devel] [PATCH v5 08/19] target/arm: optimize cross-page direct jumps in softmmu, Richard Henderson, 2017/04/27