[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [virtio-dev] [PATCH v18 0/2] virtio-crypto: virtio cryp
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [virtio-dev] [PATCH v18 0/2] virtio-crypto: virtio crypto device specification |
Date: |
Wed, 3 May 2017 06:29:41 +0000 |
Hi Halil,
Nice to see your feedback again :)
> -----Original Message-----
> From: Halil Pasic [mailto:address@hidden
> Sent: Wednesday, May 03, 2017 5:55 AM
> Subject: Re: [virtio-dev] [PATCH v18 0/2] virtio-crypto: virtio crypto device
> specification
>
>
> Hi Gonglei!
>
> I've started reviewing but it's going to take some time because
> I've missed the previous version (vacation) and v16 was a long
> time ago, so I have to re-check and re-learn things.
>
Yeah, it's a hard job.
> My first impression is, it reads much better that v16 but still
> has some space for improvement.
>
> One idea would be adding some references defining the
> crypto services and algorithms. IMHO it would make the
> spec a bit rounder, although from pragmatical perspective
> I think we can safely assume, that the target audience is able
> to figure out the stuff without.
>
I'm afraid there are too many references then because each algorithm
may have a rfc spec document.
Thanks,
-Gonglei
> Cheers,
> Halil
>
>
> On 04/22/2017 08:23 AM, Gonglei wrote:
> > As a non-native English speaker, I sincerely hope you
> > give me more suggestions about English style and/or
> > grammar for the spec. Thanks!
> >
> >
> > v18 -> v17:
> > - fix many English grammar problems suggested by Stefan, Thanks a lot!
> >
> > v17 -> v16:
> > - Some grammar fixes [Stefan, Halil, Michael]
> > - add a section named "Supported crypto services" in order to explain bit
> > numbers and valuse clearly. [Halil, Cornelia]
> > - avoid word reptition [Halil]
> > - rename non-session mode to stateless mode [Halil]
> > - change descriptions for all elements in struct virtio_crypto_config
> > [Halil]
> > - add Halil as a reviewer in the ackonwledgement part, thanks for his work.
> > - other fixes here and there.
> >
> > Changes since v15:
> > - use feature bits for non-session mode in order to keep compatibility with
> > pre-existing code. [Halil & Michael]
> > - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control
> all other
> > non-session mode feature bits.
> > - fix some typos. [Stefan]
> > - introduce struct virtio_crypto_op_data_req_mux to support both session
> > and non-session based crypto operations and keep compatibility with
> > pre-existing code.
> >
> > Changes since v14:
> > - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia]
> > - correct a sentence about dataqueue and controlq in the first paragraph.
> [Halil]
> > - change a MAY to MUST about max_dataqueues. [Halil]
> > - add non-session mode support
> > a) add four features for different crypto services to identify wheather
> support session mode.
> > b) rewrite some
> >
> > For pervious versions of virtio crypto spec, Pls see:
> >
> > [v14]:
> > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html
> >
> > [v13]:
> > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html
> >
> > For more information, please see:
> > http://qemu-project.org/Features/VirtioCrypto
> >
> >
> > Gonglei (2):
> > virtio-crypto: Add virtio crypto device specification
> > virtio-crypto: Add conformance clauses
> >
> > acknowledgements.tex | 2 +
> > conformance.tex | 29 ++
> > content.tex | 2 +
> > virtio-crypto.tex | 1309
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 1342 insertions(+)
> > create mode 100644 virtio-crypto.tex
> >