[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RESEND v2 11/21] allwinner-ahci: Remove user_creatab
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH RESEND v2 11/21] allwinner-ahci: Remove user_creatable flag |
Date: |
Wed, 3 May 2017 17:35:54 -0300 |
allwinner-ahci needs its IRQ to be connected and mmio to be
mapped (this is done by the alwinner-a10 device realize method),
and won't work with -device. Remove the user_creatable flag from
the device class.
Cc: John Snow <address@hidden>
Cc: address@hidden
Cc: Beniamino Galvani <address@hidden>
Cc: Peter Maydell <address@hidden>
Cc: address@hidden
Cc: Marcel Apfelbaum <address@hidden>
Acked-by: John Snow <address@hidden>
Acked-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
Changes v1 -> v2:
* Commit message rewrite only
---
hw/ide/ahci.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 2ea1a282ef..f60826d6e0 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1815,11 +1815,6 @@ static void allwinner_ahci_class_init(ObjectClass
*klass, void *data)
DeviceClass *dc = DEVICE_CLASS(klass);
dc->vmsd = &vmstate_allwinner_ahci;
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
- dc->user_creatable = true;
}
static const TypeInfo allwinner_ahci_info = {
--
2.11.0.259.g40922b1
- Re: [Qemu-devel] [PATCH RESEND v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, (continued)
Re: [Qemu-devel] [PATCH RESEND v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Markus Armbruster, 2017/05/15
[Qemu-devel] [PATCH RESEND v2 06/21] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 08/21] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 07/21] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 09/21] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 10/21] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 12/21] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 11/21] allwinner-ahci: Remove user_creatable flag,
Eduardo Habkost <=
[Qemu-devel] [PATCH RESEND v2 13/21] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 15/21] esp: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 14/21] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 16/21] generic-sdhci: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 17/21] hpet: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 18/21] sysbus-ohci: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 19/21] virtio-mmio: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 20/21] xen-sysdev: Remove user_creatable flag, Eduardo Habkost, 2017/05/03