[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND v2 19/21] virtio-mmio: Remove user_creata
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH RESEND v2 19/21] virtio-mmio: Remove user_creatable flag |
Date: |
Wed, 3 May 2017 23:48:27 +0300 |
On Wed, May 03, 2017 at 05:36:02PM -0300, Eduardo Habkost wrote:
> virtio-mmio needs to be wired and mapped by other device or board
> code, and won't work with -device. Remove the user_creatable flag
> from the device class.
>
> Cc: Laszlo Ersek <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Shannon Zhao <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Reviewed-by: Laszlo Ersek <address@hidden>
> Acked-by: Marcel Apfelbaum <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
> ---
> Changes v1 -> v2:
> * (none)
> ---
> hw/virtio/virtio-mmio.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
> index 6491a771ff..5807aa87fe 100644
> --- a/hw/virtio/virtio-mmio.c
> +++ b/hw/virtio/virtio-mmio.c
> @@ -450,11 +450,6 @@ static void virtio_mmio_class_init(ObjectClass *klass,
> void *data)
> dc->reset = virtio_mmio_reset;
> set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> dc->props = virtio_mmio_properties;
> - /*
> - * FIXME: Set only because we are not sure yet if this device
> - * will be outside the q35 sysbus whitelist.
> - */
> - dc->user_creatable = true;
> }
>
> static const TypeInfo virtio_mmio_info = {
> --
> 2.11.0.259.g40922b1
- [Qemu-devel] [PATCH RESEND v2 12/21] isabus-bridge: Remove user_creatable flag, (continued)
- [Qemu-devel] [PATCH RESEND v2 12/21] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 11/21] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 13/21] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 15/21] esp: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 14/21] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 16/21] generic-sdhci: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 17/21] hpet: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 18/21] sysbus-ohci: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 19/21] virtio-mmio: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
- Re: [Qemu-devel] [PATCH RESEND v2 19/21] virtio-mmio: Remove user_creatable flag,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH RESEND v2 20/21] xen-sysdev: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 21/21] s390-pcibus: No need to set user_creatable=false explicitly, Eduardo Habkost, 2017/05/03
- Re: [Qemu-devel] [PATCH RESEND v2 00/21] qdev/sysbus: Set user_creatable=false by default on sysbus, Eduardo Habkost, 2017/05/12