Re: [Qemu-devel] [PATCH 05/11] blockjob: separate monitor and blockjob APIs

[Stefan Hajnoczi]

On Wed, Apr 19, 2017 at 04:42:13PM +0200, Paolo Bonzini wrote:
> We have two different headers for block job operations, blockjob.h
> and blockjob_int.h.  The former contains APIs called by the monitor,
> the latter contains APIs called by the block job drivers and the
> block layer itself.
> 
> Keep the two APIs separate in the blockjob.c file too.  This will
> be useful when transitioning away from the AioContext lock, because
> there will be locking policies for the two categories, too---the
> monitor will have to call new block_job_lock/unlock APIs, while blockjob
> APIs will take care of this for the users.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>         v1->v2: move blockjob_create in the blockjob_int.h category,
>         rewrite commit message [John]
> 
>  blockjob.c | 390 
> ++++++++++++++++++++++++++++++++-----------------------------
>  1 file changed, 205 insertions(+), 185 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature