Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

[Kashyap Chamarthy]

On Thu, May 04, 2017 at 11:25:25AM +0100, Dr. David Alan Gilbert wrote:
> * Kashyap Chamarthy (address@hidden) wrote:
> > On Wed, May 03, 2017 at 11:42:57AM +0100, Dr. David Alan Gilbert (git) 
> > wrote:

[...]

> > > +#ifndef CONFIG_LIVE_BLOCK_MIGRATION
> > > +    if (params.blk || params.shared) {
> > > +        error_setg(errp, "QEMU compiled without old-style block 
> > > migration. "
> > > +                         "Use drive_mirror+NBD.");
> > 
> > Is it worth spelling out briefly what the "old-style block
> > migration" is?  Something like:
> > 
> >     "QEMU compiled without old-style (i.e. QMP `migrate` with
> >     "inc":true) block migration. Use `drive-mirror`+NBD")
> >  
> > But I also wonder if it's needlessly wordy, so your call to
> > incorporate it or not.
> 
> I was trying to find a short way to say it, and that's the closest I
> got to.

Fair enough.

> > I spelled out the QMP equivalent (as opposed to HMP: 'migrate -b')
> > because, that's what users of higher layers (libvirt, OpenStack etc)
> > see in their QMP interactions with QEMU, when the old-style approach
> > is used:
> > 
> >     
> > {"execute":"migrate","arguments":{{"detach":true,"blk":false,"inc":true,"uri":"fd:migrate"}
> 
> But would openstack users even know about QMP?

No, they're not expected to know of it.  Only developers digging into
Nova Vir driver issues that trickle down to QEMU normally know about it.

-- 
/kashyap