[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/21] docker: add --include-file argument to
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/21] docker: add --include-file argument to 'build' command |
Date: |
Tue, 9 May 2017 20:31:34 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, 05/09 09:14, Philippe Mathieu-Daudé wrote:
> >
> > Is it more useful if it's '--include-files' that accepts multiple files? Or
> > alternatively allow this option to be use multiple times:
> >
> > -f foo -f bar -f ...
>
> I agree, since I'm not confident with Python so I tried to touch as little
> as possible.
>
> One iter I'm thinking about do a consistent rename with the
> "dockerfiles/%.docker -> docker.d/%/Dockerfile" pattern and adding git
> symlinks to required EXTRA_FILES in each dir, to avoid the call to docker.py
> and be able to build/push images on hub.docker.com directly.
Originally I thought about "$QEMU/tests/docker/dockerfiles/$IMAGE/Dockerfile"
but that sounded too fussy.
"$QEMU/tests/docker/docker.d/$IMAGE/Dockerfile" is a bit better.
But I'm not sure doing that can allow us to remove the necessity of docker.py -
it does more such as calling .pre and passing in env vars etc..
Fam
- [Qemu-devel] [PATCH v2 00/21] docker/shippable: cross-build mipsel and powerpc targets, Philippe Mathieu-Daudé, 2017/05/08
- [Qemu-devel] [PATCH v2 01/21] docker: let _copy_with_mkdir() sub_path argument be optional, Philippe Mathieu-Daudé, 2017/05/08
- [Qemu-devel] [PATCH v2 03/21] docker: add 'apt-fake' script which generate fake debian packages, Philippe Mathieu-Daudé, 2017/05/08
- [Qemu-devel] [PATCH v2 04/21] docker: install ca-certificates package in base image, Philippe Mathieu-Daudé, 2017/05/08
- [Qemu-devel] [PATCH v2 05/21] docker: compact debian base, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-devel] [PATCH v2 06/21] docker: compact debian armhf, Philippe Mathieu-Daudé, 2017/05/08