[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] scsi: megasas: check request object in MegasasCmd
From: |
P J P |
Subject: |
[Qemu-devel] [PATCH] scsi: megasas: check request object in MegasasCmd |
Date: |
Wed, 10 May 2017 16:43:50 +0530 |
From: Prasad J Pandit <address@hidden>
When processing completed commands, if SCSIRequest object
'cmd->req' was null, it could lead to null pointer dereference
in megasas_complete_command. Add check to avoid it.
Reported-by: Zhangyanyu <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
---
hw/scsi/megasas.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index 84b8caf..25e3541 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -580,9 +580,11 @@ static void megasas_complete_command(MegasasCmd *cmd)
cmd->iov_size = 0;
cmd->iov_offset = 0;
- cmd->req->hba_private = NULL;
- scsi_req_unref(cmd->req);
- cmd->req = NULL;
+ if (cmd->req) {
+ cmd->req->hba_private = NULL;
+ scsi_req_unref(cmd->req);
+ cmd->req = NULL;
+ }
megasas_unmap_frame(cmd->state, cmd);
megasas_complete_frame(cmd->state, cmd->context);
--
2.9.3
- [Qemu-devel] [PATCH] scsi: megasas: check request object in MegasasCmd,
P J P <=