Re: [Qemu-devel] [PATCH] Revert "hw/pci: disable pci-bridge's shpc by default"

[Paolo Bonzini]

On 10/05/2017 11:29, Marcel Apfelbaum wrote:
> +++ b/hw/pci-bridge/pci_bridge_dev.c
> @@ -163,7 +163,7 @@ static Property pci_bridge_dev_properties[] = {
>      DEFINE_PROP_ON_OFF_AUTO(PCI_BRIDGE_DEV_PROP_MSI, PCIBridgeDev, msi,
>                              ON_OFF_AUTO_AUTO),
>      DEFINE_PROP_BIT(PCI_BRIDGE_DEV_PROP_SHPC, PCIBridgeDev, flags,
> -                    PCI_BRIDGE_DEV_F_SHPC_REQ, false),
> +                    PCI_BRIDGE_DEV_F_SHPC_REQ, true),
>      DEFINE_PROP_END_OF_LIST(),
>  };
>  
> diff --git a/include/hw/compat.h b/include/hw/compat.h
> index 846b90e..eff021f 100644
> --- a/include/hw/compat.h
> +++ b/include/hw/compat.h
> @@ -18,10 +18,6 @@
>          .property = "old-multiple-chip-handling",\
>          .value    = "on",\
>      },{\
> -        .driver   = "pci-bridge",\
> -        .property = "shpc",\
> -        .value    = "on",\
> -    },{\

Unless we make a conscious decision to break PCI bridge backwards
compatibility, you now have to disable it for 2.9 and leave this
HW_COMPAT_2_8 hunk intact.  Peter Xu has a patch to add the 2.10 machine
types.

Paolo

>          .driver   = TYPE_PCI_DEVICE,\
>          .property = "x-pcie-extcap-init",\
>          .value    = "off",\
> -- 2.9.3