[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling |
Date: |
Wed, 10 May 2017 15:00:09 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/10/2017 03:41 AM, Pradeep Jagadeesh wrote:
> This patch enables qmp interfaces for the fsdev
> devices. This provides two interfaces one
> for querying info of all the fsdev devices. The second one
> to set the IO limits for the required fsdev device.
>
> Signed-off-by: Pradeep Jagadeesh <address@hidden>
> ---
> +++ b/qmp.c
> @@ -130,6 +130,21 @@ void qmp_cpu_add(int64_t id, Error **errp)
> }
> }
>
> +#ifdef _WIN64
> +
> +void qmp_fsdev_set_io_throttle(IOThrottle *arg, Error **errp)
> +{
> + return;
> +}
> +
> +IOThrottleList *qmp_query_fsdev_io_throttle(Error **errp)
> +{
> + abort();
> +}
> +
> +#endif
I think you're missing an addition to monitor.c
qmp_unregister_commands_hack() if you intend for this command to be
available only on non-windows platforms (and is your #ifdef the correct
name, or is this a Linux-only feature rather than a non-windows feature).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code, (continued)
[Qemu-devel] [PATCH v4 2/4] qmp: Create IOThrottle structure, Pradeep Jagadeesh, 2017/05/10
[Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code, Pradeep Jagadeesh, 2017/05/10
[Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling, Pradeep Jagadeesh, 2017/05/10
- Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling, Pradeep Jagadeesh, 2017/05/17
- Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling, Eric Blake, 2017/05/17
- Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling, Greg Kurz, 2017/05/17
- Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling, Eric Blake, 2017/05/17
- Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling, Pradeep Jagadeesh, 2017/05/18
Re: [Qemu-devel] [PATCH v4 0/4] fsdev: qmp interface for io throttling, no-reply, 2017/05/10