Re: [Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

[Philippe Mathieu-Daudé]

On 05/10/2017 05:12 PM, Eric Blake wrote:
> On 05/10/2017 03:05 PM, Philippe Mathieu-Daudé wrote:
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> >  scripts/coccinelle/tcg_gen_extract.cocci | 26 ++++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >  create mode 100644 scripts/coccinelle/tcg_gen_extract.cocci
> >
> > diff --git a/scripts/coccinelle/tcg_gen_extract.cocci 
> > b/scripts/coccinelle/tcg_gen_extract.cocci
> > new file mode 100644
> > index 0000000000..4080f97cc7
> > --- /dev/null
> > +++ b/scripts/coccinelle/tcg_gen_extract.cocci
> > @@ -0,0 +1,26 @@
> > +// optimize TCG using extract op
> > +//
> > +// Copyright: (C) 2017 Philippe Mathieu-Daudé. GPLv2.
>
> Unless you provide a strong reason to the contrary, new files should be
> GPLv2+ rather than GPLv2-only.

Ok sorry! Wrong copy/paste mostly.

While here, I was unsure how to add this file in MAINTAINERS for 
get_maintainer.pl since it works on many target/ directories.

Stefan just merged one of your script you added under the "QObject" 
section, it makes sens.

But does it make sens to add this one in the "Common Code" section of 
"Tiny Code Generator (TCG)"? I don't think it is useful, it will only 
bother Richard Henderson.

Maybe we should add a "Coccinelle" entry with peoples willing to 
review/help those scripts... What do you think?

Regards,

Phil.