|
| From: | Philippe Mathieu-Daudé |
| Subject: | Re: [Qemu-devel] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op |
| Date: | Wed, 10 May 2017 17:32:34 -0300 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 05/10/2017 05:20 PM, Richard Henderson wrote:
On 05/10/2017 01:05 PM, Philippe Mathieu-Daudé wrote:- tcg_gen_shri_i32(t1, t1, 8); - tcg_gen_andi_i32(t1, t1, 0x00ff00ff); + tcg_gen_extract_i32(t1, t1, 8, 0x00ff00ff);This is very wrong. See my previous comment.
Arghhh I see, I checked manually and though I had it...I'll first check with the cocci script if it can handles this better then review the serie manually before bother you again.
Thinking about it, this should be quite easy unit-testable somehow ... Not sure if I want to start this path although.
Sorry for the noise and thank a lot for the review! Phil.
| [Prev in Thread] | Current Thread | [Next in Thread] |